Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode sourcemap mappings only when necessary #1664

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

OlivierNicole
Copy link
Contributor

This was extracted from #1617. When linking, it was observed that parsing the mappings field of sourcemaps takes a big toll on the overall performance, and was unnecessary since the mappings are not modified.

compiler/lib/source_map.mli Outdated Show resolved Hide resolved
compiler/lib/source_map.mli Outdated Show resolved Hide resolved
Copy link
Member

@hhugo hhugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once the CI is happy.
I left two small comments.

@OlivierNicole
Copy link
Contributor Author

Thank you, done.

@hhugo hhugo merged commit c957bfb into ocsigen:master Sep 4, 2024
17 checks passed
@OlivierNicole OlivierNicole deleted the lazy-mappings branch September 4, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants