Improved global deadcode elimination #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
improved-deadcode-elimination
branch
from
bb2da77
to
ed8e401
Compare
|
You need to check the effect on #1612 (if not already done) |
vouillon
force-pushed
the
improved-deadcode-elimination
branch
2 times, most recently
from
b4776ee
to
b314e35
Compare
vouillon
force-pushed
the
improved-deadcode-elimination
branch
from
c8d7a75
to
1d8e0b6
Compare
vouillon
changed the title
vouillon
force-pushed
the
improved-deadcode-elimination
branch
from
1d8e0b6
to
b06b0e4
Compare
What about memory peak ? |
vouillon
force-pushed
the
improved-deadcode-elimination
branch
from
b06b0e4
to
3a52bb1
Compare
vouillon
force-pushed
the
improved-deadcode-elimination
branch
3 times, most recently
from
fbfd7f8
to
6e10aee
Compare
|
I fixed a memory / speed issue. The numbers are pretty good now. |
|
Cc @JasonGross |
hhugo
reviewed
Sep 24, 2024
|
I didn't really reviewed df60582 . The rest looks good. Happy to merge. |
And remove the `Undefined` expression from `Code.expr`.
Functions can have a large number of returned variables (typically, the body is a match with lot of cases), which resulted on an overly large of number of generated dependencies.
We were considering all instructions, even those which were inside dead functions. Refine the analysis to only take into account constraints corresponding to live code.
vouillon
force-pushed
the
improved-deadcode-elimination
branch
from
6e10aee
to
0982199
Compare
|
cc @micahcantor FYI |
vouillon
added a commit
that referenced
this pull request
Oct 18, 2024
vouillon
added a commit
that referenced
this pull request
Oct 18, 2024
vouillon
added a commit
that referenced
this pull request
Oct 18, 2024
vouillon
added a commit
that referenced
this pull request
Oct 18, 2024
hhugo
pushed a commit
that referenced
this pull request
Oct 18, 2024
hhugo
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now take into account of whether an instruction is in a live function or not when generating constraints, so that dead code can no longer result in making a variable live.
We also keep track of nested module.
The performance of the algorithm has been greatly improved as well.
On the
basic_websiteexample of Tyxml, compiled with--opt 3, I get the following reduction in code size:Here are the numbers regarding #1612, when compiling
with_bedrock2_fiat_crypto.byte. For comparison, I have included an intermediate step which just optimizes the current algorithm.