Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the typing for restricted block constructs #265

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Drup
Copy link
Member

@Drup Drup commented Apr 15, 2020

This strengthen a bit the typing for dt, address and header elements that
are not supposed to be nested.

In particular, this was allowed by tyxml (where it shouldn't):

let x = body [dl [dd [txt "foo"]; dt [a [h1 [txt "foo"]]]]]

More importantly (and that's the main reason for actually fixing this),
the coercion flow5_without_sectioning_heading_header_footer :> flow5_without_header_footer was failing which was extremely annoying in practice.

@Drup Drup force-pushed the flow_ty branch 2 times, most recently from d652f4c to 523c5e6 Compare April 22, 2021 09:21
@Drup
Copy link
Member Author

Drup commented Apr 22, 2021

I just realized this is not really backward compatible, which is mildly annoying to say the least. I'm wondering if anyone is affected except odoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant