Typo whitout → without. #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! I think I've seen that one, and didn't want to break compat for a typo :p Next version will be a major one, since there are other changes that are needed. |
|
Sure! I added one under the current version, but now that I think about it, should it be made apart if you are releasing a new major version? |
|
Yes, please create a "NEXT" section, I'll decide later what it ends up being :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a typo, so I made the corresponding changes.
Given that TyXML is used in several OCaml projects and that I'm changing the type specification, there might be other checks to do before accepting this PR as-is.