Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reported scrollbar issues #4632

Closed
wants to merge 8 commits into from
Closed

Fix reported scrollbar issues #4632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
847ef4b
Fix CMS scrollbar issue
Sep 22, 2019
9f4d06c
Fix the media manager issue
Sep 22, 2019
8872d04
future ref
Sep 22, 2019
0abc0a3
Update mediamanager.css
Sep 22, 2019
a8be695
Added position sticky polyfill for IE11 support
Sep 23, 2019
2ea424c
Little tidy up
Sep 23, 2019
e72d40d
Updated Internet Explorer fix
Sep 24, 2019
f689771
typo
Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/backend/assets/css/october.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,12 @@
.control-simplelist.is-selectable-box li a:hover .image >i {color:rgba(0,0,0,0.45)}
.list-preview .control-simplelist.is-selectable ul {margin-bottom:0}
.drag-noselect {-webkit-user-select:none;-moz-user-select:none;-ms-user-select:none;user-select:none}
@media all and (-ms-high-contrast:none) {::-ms-backdrop,.control-scrollbar > .scrollbar-scrollbar .scrollbar-track .scrollbar-thumb{position:absolute !important }}
.control-scrollbar {position:relative;overflow:hidden;height:100%;-webkit-transform:translateZ(0);-ms-transform:translateZ(0);transform:translateZ(0)}
.control-scrollbar >div {-webkit-transform:translateZ(0);-ms-transform:translateZ(0);transform:translateZ(0)}
.control-scrollbar >.scrollbar-scrollbar {position:absolute;z-index:100}
.control-scrollbar >.scrollbar-scrollbar .scrollbar-track {background-color:transparent;position:relative;-webkit-border-radius:5px;-moz-border-radius:5px;border-radius:5px}
.control-scrollbar >.scrollbar-scrollbar .scrollbar-track .scrollbar-thumb {background-color:rgba(0,0,0,0.35);-webkit-border-radius:5px;-moz-border-radius:5px;border-radius:5px;cursor:pointer;overflow:hidden;position:absolute}
.control-scrollbar >.scrollbar-scrollbar .scrollbar-track .scrollbar-thumb {background-color:rgba(0,0,0,0.35);-webkit-border-radius:5px;-moz-border-radius:5px;border-radius:5px;cursor:pointer;overflow:hidden;position:sticky}
.control-scrollbar >.scrollbar-scrollbar.disabled {display:none !important}
.control-scrollbar.vertical >.scrollbar-scrollbar {right:0;margin-right:5px;width:6px}
.control-scrollbar.vertical >.scrollbar-scrollbar .scrollbar-track {height:100%;width:6px}
Expand Down
23 changes: 22 additions & 1 deletion modules/backend/assets/less/controls/scrollbar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,26 @@

@scrollbar-thumb-size: 6px;

//
// IE11 Hack to bypass position:sticky on line 55
//
@media all and (-ms-high-contrast:none) {
* {
&::-ms-backdrop {
position: absolute !important;
}
}
.control-scrollbar {
>.scrollbar-scrollbar {
.scrollbar-track {
.scrollbar-thumb {
position: absolute !important;
}
}
}
}
}

.control-scrollbar {
position: relative;
overflow: hidden;
Expand All @@ -31,7 +51,8 @@
.border-radius(5px);
cursor: pointer;
overflow: hidden;
position: absolute;
/* Important use position: sticky - see github issue: https://github.com/octobercms/october/issues/4621 */
position: sticky;
}
}

Expand Down
3 changes: 2 additions & 1 deletion modules/backend/widgets/mediamanager/assets/css/mediamanager.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions modules/backend/widgets/mediamanager/assets/less/mediamanager.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,3 +698,15 @@ body:not(.no-select) {
}
}
}

//
// Important - The right sidebar panel needs to be displayed and not hidden
// for the scrollbar to work. In this case I have overwritten the hide class
// for display:none and used opacity: 0 see github issue: https://github.com/octobercms/october/issues/4601
//
#right-sidebar-mediamanager.hide {
display: table-cell !important;
opacity: 0;
width: 0px !important;
overflow: hidden;
}
2 changes: 1 addition & 1 deletion modules/backend/widgets/mediamanager/partials/_body.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
</div>
</div>

<div class="layout-cell w-300 panel border-left no-padding <?= !$sidebarVisible ? 'hide' : null ?>" data-control="preview-sidebar">
<div id="right-sidebar-mediamanager" class="layout-cell w-300 panel border-left no-padding <?= !$sidebarVisible ? 'hide' : null ?>" data-control="preview-sidebar">
<!-- Right sidebar -->
<?= $this->makePartial('right-sidebar') ?>
</div>
Expand Down