Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @octokit/types to fix Deno compat #483

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

wolfy1339
Copy link
Member

See octokit/octokit.js#2762 (comment)

Resolves #ISSUE_NUMBER


Before the change?

  • Types would include a reference to @types/node even though there is nothing using Node specific APIs in the types

After the change?

  • Update @octokit/types to make sure types are platform agnostic

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Dec 28, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@oscard0m oscard0m merged commit e01d470 into main Dec 29, 2024
9 checks passed
@oscard0m oscard0m deleted the fix-types branch December 29, 2024 15:51
Copy link

🎉 This PR is included in version 6.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants