Remove delete_recursively
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punchagan
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Nice! Thanks for taking care of this.
From the placement of the comment, it looks like the win32_unlink and unlink may also be artifacts of the delete_recursively function. I took a quick look and didn't find uses of this unlink function too. If it's not being used anywhere, could those go too?
|
I confirm that all these functions can be removed now that they've been exposed from Lwt. |
Looks like this was copied from Lwt at some point. It is not used within obuilder currently, nor have I found it used in any of our other projects. And it has since been exposed in Lwt. See https://github.com/ocsigen/lwt/blob/48abed72467ca7479e95f1be06d02f40c7c434bd/CHANGES#L25
shonfeder
force-pushed
the
remove-dead-code
branch
from
06d28d9
to
cc1d20b
Compare
|
Thank you for the reviews (and for spotting the extra dead code, @punchagan)! |
MisterDA
approved these changes
Sep 19, 2024
|
The CI errors are spurious, and recorded in issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was copied from Lwt at some point. It is not used within obuilder currently, nor have I found it used in any of our other projects. And it has since been exposed in Lwt. See https://github.com/ocsigen/lwt/blob/48abed72467ca7479e95f1be06d02f40c7c434bd/CHANGES#L25