-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QEMU backend #195
base: master
Are you sure you want to change the base?
QEMU backend #195
Conversation
af41390
to
e854a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool work!
I would refactor the Makefile to put version numbers into variables to ease updating the Makefile, if needed.
lib/store_spec.ml
Outdated
@@ -60,7 +66,7 @@ let store_t = Arg.conv (of_string, pp) | |||
let store ?docs names = | |||
Arg.opt Arg.(some store_t) None @@ | |||
Arg.info | |||
~doc:"$(docv) must be one of $(b,btrfs:/path), $(b,rsync:/path), $(b,xfs:/path), $(b,overlayfs:/path), $(b,zfs:pool) or $(b,docker:path) for the OBuilder cache." | |||
~doc:"$(docv) must be one of $(b,btrfs:/path), $(b,rsync:/path), $(b,xfs:/path), $(b,overlayfs:/path), $(b,zfs:pool), $(b,qmu:/path) or $(b,docker:path) for the OBuilder cache." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~doc:"$(docv) must be one of $(b,btrfs:/path), $(b,rsync:/path), $(b,xfs:/path), $(b,overlayfs:/path), $(b,zfs:pool), $(b,qmu:/path) or $(b,docker:path) for the OBuilder cache." | |
~doc:"$(docv) must be one of $(b,btrfs:/path), $(b,rsync:/path), $(b,xfs:/path), $(b,overlayfs:/path), $(b,zfs:pool), $(b,qemu:/path) or $(b,docker:path) for the OBuilder cache." |
doc/qemu.md
Outdated
``` | ||
|
||
Moving on to the next stage in the build which is the `run` directive. | ||
First, `qemu-img` creates a snapshot of the current `resuilt` layer into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, `qemu-img` creates a snapshot of the current `resuilt` layer into | |
First, `qemu-img` creates a snapshot of the current `result` layer into |
This is pretty cool! If you install Docker in your base image, you could even have obuilder-in-obuilder working :p |
This PR adds a QEMU sandbox which allows testing in Windows (and Linux) virtual machines.