Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support as experimental #980

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mtelvers
Copy link
Member

No description provided.

@@ -22,6 +23,7 @@ module Pool_name = struct
| `Linux_riscv64 -> "linux-riscv64"
| `Macos_x86_64 -> "macos-x86_64"
| `Macos_ARM64 -> "macos-arm64"
| `Windows_x86_64 -> "test"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want sensible string encodings of the Windows platform here.

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, missed the context of the full change, and just saw the latest commit come thru XD

@shonfeder shonfeder self-requested a review October 31, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants