Separate triggering and nontriggering Docker build arguments #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
force-pushed
the
current-ocluster-cache
branch
from
3c8becc
to
baf3311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in https://github.com/tarides/infrastructure/issues/285, sometimes we would like to have build argument inputs that, when changed, do not trigger a rebuild. This is useful for a staging environment vs a live environment.
However, specifying only Docker build args as triggering or nontriggering is very use-case-specific. Ideally we would have a more streamlined way to specify all inputs as either triggering or nontriggering, but this would require quite a bit of refactoring.
This is a breaking change; at the very least
ocurrent-deployerwill have to be modified as well.