Track errors as a list instead of a list option

ocurrent · Aug 21, 2024 · a01c993 · a01c993
1 parent 68def2c
commit a01c993
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/bin/main.ml b/bin/main.ml
@@ -14,10 +14,10 @@ let lint (changed_pkgs, new_pkgs) local_repo_dir =
   | Some d -> (
       print_endline @@ Printf.sprintf "Linting opam-repository at %s ..." d;
       match Lint.check ~new_pkgs ~changed_pkgs d with
-      | None ->
+      | [] ->
           print_endline "No errors";
           Ok ()
-      | Some errors ->
+      | errors ->
           errors |> List.map Lint.msg_of_error |> String.concat "\n"
           |> Result.error)
 

diff --git a/lib/lint.ml b/lib/lint.ml
@@ -524,6 +524,4 @@ let check ~new_pkgs ~changed_pkgs repo_dir =
     List.map (run_package_lint ~newly_published:true ~repo_dir) new_pkgs
     |> List.concat
   in
-  match new_pkg_errors @ changed_errors with
-  | [] -> None
-  | errors -> Some errors
+  new_pkg_errors @ changed_errors