Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra metadata dict, initialized inside from_owl_uri #697

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

burnout87
Copy link
Collaborator

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.36%. Comparing base (6f20aa8) to head (453b374).
Report is 8 commits behind head on master.

Files Patch % Lines
cdci_data_analysis/analysis/parameters.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   62.34%   62.36%   +0.01%     
==========================================
  Files          50       50              
  Lines        8950     8957       +7     
==========================================
+ Hits         5580     5586       +6     
- Misses       3370     3371       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87
Copy link
Collaborator Author

example of using the label entry inside the extra_metadata entry of the object returned from the reprJSONifiable function

image

@volodymyrss volodymyrss linked an issue Jul 24, 2024 that may be closed by this pull request
@burnout87 burnout87 changed the title extra metadata dict, initialized inside from_owl_uri extra metadata dict, initialized inside from_owl_uri Aug 12, 2024
@burnout87
Copy link
Collaborator Author

with the group entry inside the extra_metadata

image

@burnout87
Copy link
Collaborator Author

burnout87 commented Aug 13, 2024

These screenshots have been generated using the notebook on my repository:

https://gitlab.renkulab.io/gabriele.barni/photoz-euclid/-/blob/master/Run_Phosphoros_preComputedMG.ipynb

In particular, the following parameters have been grouped together:

  • column_name_MW_EBV, column_name_RA and column_name_DEC - group: "Milky Way Extinction"
  • column_name_Ztrue, ZP_correction and PDZ_output - group "Redshift"

As a test, I also created the group "File group test" with the parameters catalog_URL and catalog_string

@burnout87 burnout87 marked this pull request as ready for review August 16, 2024 06:31
@burnout87 burnout87 merged commit 6483081 into master Aug 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants