Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot tools in oda_api #706

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Plot tools in oda_api #706

wants to merge 1 commit into from

Conversation

dsavchenko
Copy link
Member

Following oda-hub/oda_api#279
Removing code duplication in plot_tools

@dsavchenko
Copy link
Member Author

@volodymyrss there are unige-related connection errors in tests

@volodymyrss
Copy link
Member

Some UNIGE servers are down for an upgrade today. The tests fetch test products from there. Could you maybe add a label and conditionally skip them to see that all else is good?..

@dsavchenko
Copy link
Member Author

Could you maybe add a label and conditionally skip them to see that all else is good?..

Well, this PR is almost empty now, and it is currently to check compatibility of dependencies.
So we can just wait for these servers

@volodymyrss
Copy link
Member

Could you maybe add a label and conditionally skip them to see that all else is good?..

Well, this PR is almost empty now, and it is currently to check compatibility of dependencies. So we can just wait for these servers

Normally the maintainance should be over, so perhaps there was a problem. I asked.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.33%. Comparing base (6e98f24) to head (2778e6e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #706   +/-   ##
=======================================
  Coverage   62.33%   62.33%           
=======================================
  Files          50       50           
  Lines        8982     8982           
=======================================
  Hits         5599     5599           
  Misses       3383     3383           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsavchenko dsavchenko linked an issue Aug 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try to use visualizations from oda_api in dispatcher?
2 participants