Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in case local resolver fails, fallback to the external resolver #712

Merged
merged 13 commits into from
Oct 3, 2024
Merged

in case local resolver fails, fallback to the external resolver #712

merged 13 commits into from
Oct 3, 2024
+269 −43

Conversation

burnout87
Copy link
Collaborator

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 2, 2024
View reviewed changes
cdci_data_analysis/pytest_fixtures.py Fixed Show fixed Hide fixed
cdci_data_analysis/pytest_fixtures.py
@@ -708,10 +751,21 @@
yield yaml.load(open(dispatcher_test_conf_with_gallery_fn), Loader=yaml.SafeLoader)['dispatcher']


@pytest.fixture
def dispatcher_test_conf_with_gallery_invalid_local_resolver(dispatcher_test_conf_with_gallery_invalid_local_resolver_fn):
yield yaml.load(open(dispatcher_test_conf_with_gallery_invalid_local_resolver_fn), Loader=yaml.SafeLoader)['dispatcher']

Check warning

Code scanning / CodeQL

File is not always closed Warning

File is opened but is not closed.
cdci_data_analysis/pytest_fixtures.py

@pytest.fixture
def dispatcher_test_conf_with_vo_options(dispatcher_test_conf_with_vo_options_fn):
yield yaml.load(open(dispatcher_test_conf_with_vo_options_fn), Loader=yaml.SafeLoader)['dispatcher']

Check warning

Code scanning / CodeQL

File is not always closed Warning

File is opened but is not closed.
@burnout87
Copy link
Collaborator Author

In case the local resolver is not reachable, then the external resolver is used.

This is the same approach used by the frontend

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 12.50000% with 105 lines in your changes missing coverage. Please review.

Project coverage is 61.90%. Comparing base (eb99daa) to head (7a39559).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
cdci_data_analysis/analysis/drupal_helper.py 3.57% 81 Missing ⚠️
cdci_data_analysis/pytest_fixtures.py 33.33% 20 Missing ⚠️
cdci_data_analysis/flask_app/app.py 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   62.40%   61.90%   -0.51%     
==========================================
  Files          50       50              
  Lines        9002     9096      +94     
==========================================
+ Hits         5618     5631      +13     
- Misses       3384     3465      +81

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87 burnout87 mentioned this pull request Oct 3, 2024
Merged
@burnout87 burnout87 marked this pull request as ready for review October 3, 2024 16:20
dsavchenko
dsavchenko approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware resolver is used from the dispatcher. Is this only gallery-related?

@burnout87
Copy link
Collaborator Author

I wasn't aware resolver is used from the dispatcher. Is this only gallery-related?

This one is, at the moment, used for the gallery

@burnout87 burnout87 merged commit 2d00c76 into master Oct 3, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyrss volodymyrss volodymyrss approved these changes

@dsavchenko dsavchenko dsavchenko approved these changes

Assignees
No one assigned
Labels
test-oda-api test-plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burnout87 @volodymyrss @dsavchenko