fix test no backend #106
Merged
fix test no backend #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burnout87
approved these changes
Aug 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test that requires backend to be unavailable started to fail (https://github.com/oda-hub/dispatcher-app/actions/runs/10352765910/job/28765875291) due to recent update in
pytest-httpserverlibrary.Normally, due to the documentation the mock server stays alive between tests, just resetting its "state". Given that, one can't expect it to be unreachable in this test anyway, and the test used to work only because of the peculiarities of how and when the server state is being reset.
Moving this test to be run before mock server was started to assure it works correctly. (Normally, pytest respects the ordering of the tests in the module, from top to bottom.)
Also, this PR includes changes to make sure that subprocesses (if any) of xprocess-started backend are killed