Include return progress arg

[burnout87]

No description provided.

[dsavchenko]

jobdir added to the response of nb2service for running jobs by oda-hub/nb2workflow#129

[burnout87]

First round of review, mainly to understand if something is missing.

a small change in the dispatcher oda-hub/dispatcher-app#632 will also be needed

[dsavchenko]

That's nice overall.

We need to agree on how this is treated by both frontend and oda_api to properly structure the dispatcher response, so we can get rid of unneded product methods (e.g. we don't really required to save this notebook representation into file with write if there won't be a "download" button)

[dsavchenko]

Edge cases:

1. There is no such job in backend (normally, this doesn't happen, of course). In this case, we need to keep both _async_request_callback and _async_request in the request, the job will be submitted just like with run_query(). May be, there is even no need for additional adaptations. But the jobdir will most probably be None (see case 2)
2. If the job is submitted to the async queue, but is not already running (status=submitted), the jobdir hasn't been set yet and will be returned as None. Needs separate treatment.
3. Synchronous request. Not sure if this will work at all (at least I didn't do any adaptations to nb2workflow regarding jobdir for synchronous case). Need to check. (But generally speaking, synchronous backend is only applicable to really short jobs, and there is no need to track progress. Probably it makes sense to just disable this method somehow in this case?)

[dsavchenko]

So, if I understand correctl the _async_request_callback arg is needed.

Seems so, finally

[dsavchenko]

Only one fix and cool overall!

I only wonder how the response will then be used on the frontend side. We have full page html in json, how to show it there?