-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Galaxy #40
Galaxy #40
Conversation
dsavchenko
commented
Nov 3, 2023
•
edited
Loading
edited
- sometimes creates duplicated PRs
Example of the automatic PR esg-epfl-apc/tools-astro#46 What's missing now, is .shed.yml file generation. But here, need to decide where this info (at least description and long_description are needed) comes from. Does workflow creator need to create a file with some fields defined, or just provide full .shed.yml? There is also uncertainty in how to bump tool version properly. Otherwise, the basic tool creation works |
branches should be probably created right in org repo, not in your own. Else secrets are not used (and they should not be) |
Yes, it is a configurable parameter |
I need your advice, @bgruening |
I don't know :-( can you explain your use-case? Maybe we can brainstorm how tomsolve it differently. |
This is for the bot to decide the version of the next autogenerated tool release. I thought of the toolshed to be a single source of truth for the latest version already available. But if this is complicated, I can rely on the version of the tool in the main branch of our repo https://github.com/esg-epfl-apc/tools-astro/ assuming it's the only one with CI configured to push into the toolshed |
I see. We use GitHub. We follow those recommendations for numbering https://galaxy-iuc-standards.readthedocs.io/en/latest/best_practices/tool_xml.html and then let our bot increase the number. |
@dsavchenko it seems ready and approved. Maybe let's merge it and make further changes with new PRs as needed? Or something essential is missing? |
I wanted to merge it when the first generated tool is ready to be pushed to the toolshed (we are very close to this). |
Ok, good, so I turn it draft. |
When oda-hub/nb2workflow#102 is merged, the nb2workflow branch needs to be changed in The first autogenerated tool PR esg-epfl-apc/tools-astro#82 looks good now. |