Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy #40

Merged
merged 28 commits into from
Feb 27, 2024
Merged

Galaxy #40

merged 28 commits into from
Feb 27, 2024

Conversation

dsavchenko
Copy link
Member

@dsavchenko dsavchenko commented Nov 3, 2023

  • sometimes creates duplicated PRs

@dsavchenko dsavchenko marked this pull request as ready for review November 7, 2023 17:45
@dsavchenko
Copy link
Member Author

dsavchenko commented Nov 7, 2023

Example of the automatic PR esg-epfl-apc/tools-astro#46

What's missing now, is .shed.yml file generation. But here, need to decide where this info (at least description and long_description are needed) comes from. Does workflow creator need to create a file with some fields defined, or just provide full .shed.yml?

There is also uncertainty in how to bump tool version properly.

Otherwise, the basic tool creation works

odabot/cli.py Outdated Show resolved Hide resolved
@volodymyrss
Copy link
Member

branches should be probably created right in org repo, not in your own. Else secrets are not used (and they should not be)

@dsavchenko
Copy link
Member Author

branches should be probably created right in org repo

Yes, it is a configurable parameter

volodymyrss
volodymyrss previously approved these changes Jan 8, 2024
@dsavchenko
Copy link
Member Author

I need your advice, @bgruening
Is it possible to directly query the toolshed API to get the list of available versions of the specific tool (by tool ID) there?
I only found tool version info in the galaxy instance API (for the installed tools, I guess), but in the toolshed API I only see revision hashes, and it's not clear how to match them with the tool version

@bgruening
Copy link

I don't know :-( can you explain your use-case? Maybe we can brainstorm how tomsolve it differently.

@dsavchenko
Copy link
Member Author

I don't know :-( can you explain your use-case? Maybe we can brainstorm how tomsolve it differently.

This is for the bot to decide the version of the next autogenerated tool release. I thought of the toolshed to be a single source of truth for the latest version already available. But if this is complicated, I can rely on the version of the tool in the main branch of our repo https://github.com/esg-epfl-apc/tools-astro/ assuming it's the only one with CI configured to push into the toolshed

@bgruening
Copy link

I see. We use GitHub. We follow those recommendations for numbering https://galaxy-iuc-standards.readthedocs.io/en/latest/best_practices/tool_xml.html and then let our bot increase the number.

@volodymyrss
Copy link
Member

@dsavchenko it seems ready and approved. Maybe let's merge it and make further changes with new PRs as needed? Or something essential is missing?

@dsavchenko
Copy link
Member Author

@dsavchenko it seems ready and approved. Maybe let's merge it and make further changes with new PRs as needed? Or something essential is missing?

I wanted to merge it when the first generated tool is ready to be pushed to the toolshed (we are very close to this).
I will re-request review

@volodymyrss volodymyrss marked this pull request as draft February 14, 2024 15:41
@volodymyrss
Copy link
Member

@dsavchenko it seems ready and approved. Maybe let's merge it and make further changes with new PRs as needed? Or something essential is missing?

I wanted to merge it when the first generated tool is ready to be pushed to the toolshed (we are very close to this). I will re-request review

Ok, good, so I turn it draft.

@dsavchenko
Copy link
Member Author

When oda-hub/nb2workflow#102 is merged, the nb2workflow branch needs to be changed in Dockerfile_galaxy and this PR will also be ready. I will add CI/CD to build galaxy-related container separately in the future.

The first autogenerated tool PR esg-epfl-apc/tools-astro#82 looks good now.

@dsavchenko dsavchenko marked this pull request as ready for review February 26, 2024 09:40
odabot/cli.py Outdated Show resolved Hide resolved
@dsavchenko dsavchenko merged commit 2c955da into master Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants