remove reload-plugin #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why? how does it reload then? |
|
It doesn't need to be reloaded to be aware of the instruments in KG after introducing So the reload endpoint is only used in case of changes in a static configuration file. Moreover, it can really only be used in tests, in the real production deployment there are multiple independent processes started by gunicorn and calling the reload endpoint affected only one of them, this was the reason for the disappearance of the newly added instruments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more need to reload plugin after oda-hub/dispatcher-plugin-nb2workflow#90
(it didn't work anyway due to multiple workers)