Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep names of all products + new BinaryProduct #200

Merged
merged 16 commits into from
Jun 29, 2023
Merged

Keep names of all products + new BinaryProduct #200

merged 16 commits into from
Jun 29, 2023

Conversation

dsavchenko
Copy link
Member

No description provided.

@burnout87
Copy link
Collaborator

Live test is failing in the same way as #199 (comment)

@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #200 (36fd7ef) into master (14a0fad) will increase coverage by 0.46%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   53.87%   54.33%   +0.46%     
==========================================
  Files          20       20              
  Lines        3978     4036      +58     
==========================================
+ Hits         2143     2193      +50     
- Misses       1835     1843       +8
Impacted Files Coverage Δ
oda_api/api.py 76.03% <33.33%> (-0.59%) ⬇️
oda_api/data_products.py 58.91% <78.84%> (+1.35%) ⬆️
oda_api/json.py 57.89% <100.00%> (ø)
tests/test_data_products.py 98.95% <100.00%> (+0.13%) ⬆️

... and 2 files with indirect coverage changes

@dsavchenko dsavchenko changed the title Prooducts naming Keep names of all products + new BinaryProduct Jun 28, 2023
@dsavchenko dsavchenko marked this pull request as ready for review June 28, 2023 14:57
@dsavchenko dsavchenko mentioned this pull request Jun 28, 2023
Merged
@dsavchenko dsavchenko marked this pull request as draft June 28, 2023 15:59
burnout87
burnout87 reviewed Jun 29, 2023
View reviewed changes
oda_api/data_products.py Outdated Show resolved Hide resolved
burnout87
burnout87 reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@burnout87 burnout87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments/questions

@dsavchenko dsavchenko marked this pull request as ready for review June 29, 2023 11:11
burnout87
burnout87 previously approved these changes Jun 29, 2023
View reviewed changes
@volodymyrss
Copy link
Member

what's with Untitled.ipynb

@dsavchenko
Copy link
Member Author

what's with Untitled.ipynb

It was added by mistake

@volodymyrss volodymyrss merged commit 8634e66 into master Jun 29, 2023
14 checks passed
@burnout87 burnout87 mentioned this pull request Jul 11, 2023
Closed
@dsavchenko dsavchenko mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyrss volodymyrss volodymyrss approved these changes

@burnout87 burnout87 burnout87 left review comments

Assignees
No one assigned
Labels
test-live
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsavchenko @burnout87 @volodymyrss