Encode structured param #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 58.16% 58.40% +0.23%
==========================================
Files 23 23
Lines 4840 4851 +11
==========================================
+ Hits 2815 2833 +18
+ Misses 2025 2018 -7 ☔ View full report in Codecov by Sentry. |
Closed
burnout87
requested changes
Feb 6, 2024
There was a problem hiding this comment.
I guess this will also need some test, once oda-hub/dispatcher-app#649 is merged...
|
It's tested by But I may think of adding the standalone test |
volodymyrss
approved these changes
Feb 7, 2024
burnout87
approved these changes
Feb 7, 2024
|
Could you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.