handle conflict error in instrumentation config updates #1737
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
approved these changes
Nov 14, 2024
| @@ -55,19 +56,18 @@ func (r *InstrumentedApplicationReconciler) Reconcile(ctx context.Context, req c | |||
|
|
|||
| instrumentationRules := &odigosv1.InstrumentationRuleList{} | |||
| err = r.Client.List(ctx, instrumentationRules) | |||
| if client.IgnoreNotFound(err) != nil { | |||
There was a problem hiding this comment.
can a list operation return not found? or is it only for safety?
If it's not found, don't we want to return and not cause any updates?
There was a problem hiding this comment.
Thich check is for errors which are not NotFound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typical error we see when trying to update the instrumentation config CR is:
This is due to the Get and Update pattern we use. Following #1710 , use the update error util for this case as well.
Adding to the error handling util - a check for
IsNotFounderror and ignoring it.