Remove String allocation in Interface's Display impl

odilia-app · Oct 10, 2023 · 2c759df · 2c759df
1 parent e8b23fc
commit 2c759df
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/atspi-common/src/interface.rs b/atspi-common/src/interface.rs
@@ -375,7 +375,7 @@ impl TryFrom<&str> for Interface {
 }
 impl std::fmt::Display for Interface {
 	fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
-		let interface_string = match self {
+		let interface_str = match self {
 			Interface::Accessible => ACCESSIBLE_INTERFACE_NAME,
 			Interface::Action => ACTION_INTERFACE_NAME,
 			Interface::Application => APPLICATION_INTERFACE_NAME,
@@ -396,8 +396,7 @@ impl std::fmt::Display for Interface {
 			Interface::TableCell => TABLE_CELL_INTERFACE_NAME,
 			Interface::Text => TEXT_INTERFACE_NAME,
 			Interface::Value => VALUE_INTERFACE_NAME,
-		}
-		.to_string();
-		write!(f, "{interface_string}")
+		};
+    f.write_str(interface_str)
 	}
 }