Quicken CI

[TTWNO]

No description provided.

[codecov]

Codecov Report

Merging #140 (c18d565) into main (9706107) will increase coverage by 0.77%.
Report is 21 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   89.98%   90.76%   +0.77%     
==========================================
  Files          39       40       +1     
  Lines        3176     3540     +364     
==========================================
+ Hits         2858     3213     +355     
- Misses        318      327       +9     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[TTWNO]

Huge wins for CI.

Branch	Total CI Runtime	Longest Task
main	27:18	msrv-compliance: 9:12
quicken-ci	11:54	tests: 2:30

This is an outstanding improvement!

[DataTriny]

FWIW in AccessKit CI we use dtolnay/install: it is probably as fast, but definitely more readable. And it would be able to install all the binaries you need.

Also, I really don't see the benefits of running clippy for stable and beta. Why not running it on nightly only like everyone else does these days?

[TTWNO]

Also, I really don't see the benefits of running clippy for stable and beta. Why not running it on nightly only like everyone else does these days?

I didn't know it was common to do that. I don't see any reasin why not, as long as nightly is stricter. The concern is that I don't want to be chasing down lints that end up not getting added to stable anyways.

[TTWNO]

FWIW in AccessKit CI we use dtolnay/install: it is probably as fast, but definitely more readable. And it would be able to install all the binaries you need.

I'll give this a look in my PR and see if that works just as easily. Thanks for the tip!

[DataTriny]

I don't want to be chasing down lints that end up not getting added to stable anyways.

I think it never happened to us once, and we have set up our CI more than two years ago now. clippy probably reached some sort of maturity at this point.