Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XML from upstream #161

Merged
merged 14 commits into from
Jun 16, 2024
Merged

Update XML from upstream #161

merged 14 commits into from
Jun 16, 2024

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented Mar 9, 2024

Do not merge yet. I think we have a new method to add to the Socket proxy.

@TTWNO
Copy link
Member Author

TTWNO commented Mar 9, 2024

Why did this branch before your CI fix? Strange.

@luukvanderduim
Copy link
Collaborator

It did not, I sneakily added a 'fix'.
Unfortunately it does not seem to fix anything..
The error messages looked like this:

No XML path provided and default XML path not found. Current dir: "/home/runner/work/atspi/atspi/atspi-common" 

Setting the environment variable to "../xml" broke things in more interesting ways. Not sure what is going on.
It cannot find the directory and I see other problems pop-up that do not make sense at all since all other CI tests succeed.
Do you understand this better?

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (85d7518) to head (93195c9).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   83.74%   86.69%   +2.95%     
==========================================
  Files          39       39              
  Lines        3112     3338     +226     
==========================================
+ Hits         2606     2894     +288     
+ Misses        506      444      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TTWNO TTWNO marked this pull request as draft March 11, 2024 15:11
@TTWNO
Copy link
Member Author

TTWNO commented Mar 11, 2024

TODO:

  • implement Get/Set TextSelections for Document.
  • fix docs to look like Rust docs instead of DBus XML docs

@@ -209,7 +209,7 @@ pub enum ScrollType {
/// The argument in the `Announcement` event is named `politeness`.
#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, Hash, Serialize, Deserialize, Type)]
#[repr(i32)]
pub enum Live {
pub enum Politeness {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for this.
Maybe in a certain context Live made sense at some point. (I suppose 'the way we may interrupt 'live' (ongoing) speech'.)
I think Politeness is much more descriptive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's an old relic from pre-Odilia/atspi-split days. I didn't care what I named anything because the Odilia people would be the only ones using it... I'm sure there are a few more somewhere deep in the codebase.

@TTWNO TTWNO marked this pull request as ready for review May 22, 2024 20:16
@TTWNO TTWNO requested a review from luukvanderduim May 23, 2024 18:50
@TTWNO TTWNO merged commit 6d5595c into main Jun 16, 2024
13 checks passed
@TTWNO TTWNO deleted the update-xml branch June 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants