-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XML from upstream #161
Conversation
Why did this branch before your CI fix? Strange. |
It did not, I sneakily added a 'fix'. No XML path provided and default XML path not found. Current dir: "/home/runner/work/atspi/atspi/atspi-common" Setting the environment variable to "../xml" broke things in more interesting ways. Not sure what is going on. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 83.74% 86.69% +2.95%
==========================================
Files 39 39
Lines 3112 3338 +226
==========================================
+ Hits 2606 2894 +288
+ Misses 506 444 -62 ☔ View full report in Codecov by Sentry. |
TODO:
|
@@ -209,7 +209,7 @@ pub enum ScrollType { | |||
/// The argument in the `Announcement` event is named `politeness`. | |||
#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, Hash, Serialize, Deserialize, Type)] | |||
#[repr(i32)] | |||
pub enum Live { | |||
pub enum Politeness { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks for this.
Maybe in a certain context Live
made sense at some point. (I suppose 'the way we may interrupt 'live' (ongoing) speech'.)
I think Politeness
is much more descriptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's an old relic from pre-Odilia/atspi-split days. I didn't care what I named anything because the Odilia people would be the only ones using it... I'm sure there are a few more somewhere deep in the codebase.
This reverts commit a7f7e6c. (The provided path does not seem to be correct)
In the same test tokio tests pass where async-std tests fail.
Do not merge yet. I think we have a new method to add to the Socket proxy.