Use serde derive macros on Interface
#174
Conversation
|
The FWIW I have removed some tests related to the manual serialization/deserialization of the |
No problem. It's always a bit tempermental. |
| } | ||
| } | ||
|
|
||
| impl std::fmt::Display for Interface { |
There was a problem hiding this comment.
Why have you removed the Display implementation? Does Serialize auto-implement this?
There was a problem hiding this comment.
I removed the constants so as to not have duplicate names, so we'd have to write the string literals inside the Display impl in order to keep this. But what's the added value of having this? It was only used in tests that I removed, I think the Debug impl is enough for users.
|
This removes a ton of manual code. I'm merging. |
Relates to #157
There are more complex cases where avoiding the use of the
strumcrate will require more design changes, so I'm addressing this one first.