make text selection a struct #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 86.95% 86.97% +0.02%
==========================================
Files 40 40
Lines 3518 3525 +7
==========================================
+ Hits 3059 3066 +7
Misses 459 459 ☔ View full report in Codecov by Sentry. |
TTWNO
force-pushed
the
make-text-selection-a-struct
branch
from
9949c9b
to
5e1d524
Compare
| pub type TextSelection = (ObjectRef, i32, ObjectRef, i32, bool); | ||
| /// Describes a selection of text, including selections across object boundaries. | ||
| /// For example, selecting from the beginning of a paragraph to half way through a link would cause | ||
| /// the start and end object references to be different. |
There was a problem hiding this comment.
TIL, again! Great stuff, thanks!
luukvanderduim
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #195