Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action struct #204

Merged
merged 2 commits into from
Jul 1, 2024
Merged

add action struct #204

merged 2 commits into from
Jul 1, 2024

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented Jun 27, 2024

  • Add Action struct
  • Use Action struct in proxy

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (d8e2bdb) to head (21830fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   86.95%   86.97%   +0.02%     
==========================================
  Files          40       41       +1     
  Lines        3518     3525       +7     
==========================================
+ Hits         3059     3066       +7     
  Misses        459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DataTriny
Copy link
Collaborator

Perhaps I would move the detailed description of each action components from the interface methods to the new struct fields.

@TTWNO
Copy link
Member Author

TTWNO commented Jun 29, 2024

Can you please explain what you mean? I'm not sure I understand.

@TTWNO TTWNO merged commit 3090cd3 into main Jul 1, 2024
14 checks passed
@TTWNO TTWNO deleted the add-action-struct branch July 1, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants