Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big Trait Changes #206

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Big Trait Changes #206

wants to merge 43 commits into from

Commits on Jul 5, 2024

  1. Split BusProperties into two traits

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    015ccc2 View commit details
    Browse the repository at this point in the history

  2. use new trait in sending event code

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    dd10886 View commit details
    Browse the repository at this point in the history

  3. Feature gate new MessageConversion trait behind 'zbus'

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6151aa5 View commit details
    Browse the repository at this point in the history

  4. Merge new event and body behaviour

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a3f596f View commit details
    Browse the repository at this point in the history

  5. from_message_parts_unchecked -> try_from_message_unchecked

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fe46a31 View commit details
    Browse the repository at this point in the history

  6. Pass &Message to new try_from_message_unchecked

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5ad158f View commit details
    Browse the repository at this point in the history

  7. Add macro to implement From<ObjectRef>

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    bc865fe View commit details
    Browse the repository at this point in the history

  8. Fix missing doc link

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6ad6a16 View commit details
    Browse the repository at this point in the history

  9. Auto-implement MessageConversion for trivial case.

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fe9da31 View commit details
    Browse the repository at this point in the history

  10. Remove now unused From<UFET> for EventBodyOwned

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5add99d View commit details
    Browse the repository at this point in the history

  11. Use full message to check tests

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    8578f85 View commit details
    Browse the repository at this point in the history

  12. Make sure to check signature validity before calling _unchecked

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1b2a734 View commit details
    Browse the repository at this point in the history

  13. Fix import

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0aa7380 View commit details
    Browse the repository at this point in the history

  14. Fix additional imports

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e86643c View commit details
    Browse the repository at this point in the history

  15. Using a struct in a doc item is not considered 'using' it

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5f52f93 View commit details
    Browse the repository at this point in the history

  16. Change trait bound to be more generic 

    Change trait bounds for auto-impl of MessageConversion
    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3368b83 View commit details
    Browse the repository at this point in the history

  17. Use options instead of values

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a9bb246 View commit details
    Browse the repository at this point in the history

  18. UnknownBusSignature -> SignatureMatch

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a47aaf4 View commit details
    Browse the repository at this point in the history

  19. Add HasInterfaceName trait

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c4e0c1e View commit details
    Browse the repository at this point in the history

  20. Use HasInterfaceName for ObjectEvents

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1b3791d View commit details
    Browse the repository at this point in the history

  21. Test specific errors instead of just any error

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    123e47d View commit details
    Browse the repository at this point in the history

  22. Add new tests around message conversion 

    - Correct interface, member and invalid body
- Correct body, interface and invalid member
    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    df1e36b View commit details
    Browse the repository at this point in the history

  23. Error order coherency 

    The order of validation is the following when using
`Event::try_from(Message)`:

- MissingInterface
- InterfaceMatch
- MissingMember
- MemberMatch
- MissingSignature
- SignatureMatch

Or at least, that's what it should be.
THe commit makes individual implementations of `TryFrom<Message>` cohere
to the same order of validation.
    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e4359f2 View commit details
    Browse the repository at this point in the history

  24. Use and validate correct error types

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e5a0374 View commit details
    Browse the repository at this point in the history

  25. Add blanket impl for HasInterfaceName for T: BusProperties

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c9857a1 View commit details
    Browse the repository at this point in the history

  26. Use _unchecked in more places

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ad74e27 View commit details
    Browse the repository at this point in the history

  27. Move CacheEvents and vairants into their own file

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    791dad3 View commit details
    Browse the repository at this point in the history

  28. Fix imports in test

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5107e2c View commit details
    Browse the repository at this point in the history

  29. impl EventWrapperMessageConversion for FocusEvents

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    2ff735f View commit details
    Browse the repository at this point in the history

  30. Auto-impl interface checking

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9052cf5 View commit details
    Browse the repository at this point in the history

  31. Flag zbus-only trait imports

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d9204b6 View commit details
    Browse the repository at this point in the history

  32. Use unchecked interface when possible

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c3bbdd2 View commit details
    Browse the repository at this point in the history

  33. Use constants instead of &str to match members, interfaces

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1b1f76c View commit details
    Browse the repository at this point in the history

  34. try_from_message_unchecked -> try_from_validated_message

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    370c295 View commit details
    Browse the repository at this point in the history

  35. Auto-impl MessageConversion::try_from_message for all event types

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    45d6cd0 View commit details
    Browse the repository at this point in the history

  36. Use auto-impl for TryFrom<&Message>

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    855d4df View commit details
    Browse the repository at this point in the history

  37. Add a test for try_from_validated_message; check it does not validate

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c7a657e View commit details
    Browse the repository at this point in the history

  38. Test *AccessibleEvent with explicit bodies

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    73c17b0 View commit details
    Browse the repository at this point in the history

  39. Add new methods on trait MessageConversion 

    - `validate_interface` (auto-impl)
- `validate_member` (auto-impl)
- `validate_body` (auto-impl)
- `try_from_validated_message_parts` (required)
	- This constructs the event from an to it with the arguments ObjectRef,Self::Body
    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ba2df3b View commit details
    Browse the repository at this point in the history

  40. Modify macros to work with new decomposed event system

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    96387e8 View commit details
    Browse the repository at this point in the history

  41. impl try_from_validated_message_parts for any event that needs it

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    866415b View commit details
    Browse the repository at this point in the history

  42. Make clippy happy

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    31abd35 View commit details
    Browse the repository at this point in the history

  43. Fix docs

    @TTWNO
    TTWNO committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    cb70e23 View commit details
    Browse the repository at this point in the history