refactor(bench): Dedup bench code and reduce variance between runs #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deduplicate code: Moves common code to module that is shared between tests - Reduce variance between bench runs: Generates test files with randomly generated `Messages`
|
CI's Maybe we could try |
luukvanderduim
commented
Nov 8, 2024
| @@ -568,7 +568,7 @@ impl TryFrom<&zbus::Message> for EventBodyOwned { | |||
|
|
|||
| fn try_from(message: &zbus::Message) -> Result<Self, Self::Error> { | |||
| let body = message.body(); | |||
| let signature = body.signature().ok_or_else(|| AtspiError::MissingSignature)?; | |||
| let signature = body.signature().ok_or(AtspiError::MissingSignature)?; | |||
There was a problem hiding this comment.
Clippy complained because of a new lint: needless_lazy_evaluation
This removes the path to the stored `Message`s. ```Rust cargo bench --quiet ``` or ``` cargo criterion ``` now both work as expected. The problem was that benc and criterion differ in opinion on the root. Thus the hard coded relatlive path is a problem. It is possible to obtain an absolute path at compile time but this relies on a hack. criterion will store the files in the workspace root bench will store the files in the crate root.
luukvanderduim
force-pushed
the
reduce-bench-variance
branch
from
519a437
to
a9decd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves common code to module that is shared between tests
Generates test files with randomly generated
Messages