State management tests #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=========================================
+ Coverage 9.60% 13.99% +4.38%
=========================================
Files 16 16
Lines 1520 1551 +31
=========================================
+ Hits 146 217 +71
+ Misses 1374 1334 -40
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Performance since last time the tests compiled: * Insertion is up 50-90%. * Traversal is down 50-300%. * This is very likely because the `id` field of the AccessiblePrimitve structure is now a String instead of the AccessibleId enum it was before. * Still trying to find a way to turn AccessiblePrimitive into a Copy type. * Remember that copy types should be fairly small, if possible. Certainly no more than 16 or 32 bytes.
… smartstring, which implements Copy
|
Will be completely re-written after the merge of #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for dispatching events with state.
This should bring test coverage up considerably.