Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Support #126

Merged
merged 5 commits into from
Feb 24, 2024
Merged

CLI Support #126

merged 5 commits into from
Feb 24, 2024

Conversation

C-Loftus
Copy link
Contributor

Odilia currently does not support cli args. When I first installed odilia I expected to be able to run --help to get some general info on the program. It is also useful to be able to quickly get the version and specify the config directory in case you are testing with different configurations and have multiple configs (this is likely moreso to be a useful features as more settings are added and switching between configs becomes more common)

I messed around with adding log level but I think it is confusing to users to have that be both a CLI arg and a setting in the config toml file so I kept the cli very simple for now. This should be easy to add to if more features are desired.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 14.30%. Comparing base (797956a) to head (5d758f2).

Files Patch % Lines
odilia/src/main.rs 0.00% 3 Missing ⚠️
odilia/src/cli.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   14.33%   14.30%   -0.03%     
==========================================
  Files          16       17       +1     
  Lines        1556     1559       +3     
==========================================
  Hits          223      223              
- Misses       1333     1336       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

C-Loftus and others added 2 commits February 24, 2024 17:17
update the rust-version field in Cargo.toml to the minimum version required by clap
this is done in order for the msrv check to succeed, and the pull request to be safely mergeable
@albertotirla albertotirla merged commit 026b7f4 into odilia-app:main Feb 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants