preliminary try to add a notification daemon #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is pam-dbus-notify, to be more exact. Furthermore, I'm installing notify-send, to be able to test that sending notifications actually works as expected
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 14.30% 14.30%
=======================================
Files 17 17
Lines 1559 1559
=======================================
Hits 223 223
Misses 1336 1336 ☔ View full report in Codecov by Sentry. |
now, pam-dbus-notify has been replaced by dbus-notify, and notify-send by notify-osd
the correct name appears to be simply notification-daemon, let's see if this one works
…dn't know ubuntu packages it in libnotify
… in case that hasn't been done automatically
albertotirla
force-pushed
the
add_notification_daemon
branch
from
74cea1e
to
aea7266
Compare
albertotirla
force-pushed
the
add_notification_daemon
branch
from
aea7266
to
bfafee8
Compare
…we're currently preloading the runner with
…lly this doesn't require the actualx11 display server
…ch line in the source file
This reverts commit 9d5b645.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is pam-dbus-notify, to be more exact. Furthermore, I'm installing notify-send, to be able to test that sending notifications actually works as expected