Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification improvements #135

Merged
merged 7 commits into from
Mar 9, 2024
Merged

Notification improvements #135

merged 7 commits into from
Mar 9, 2024

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented Mar 7, 2024

  • Add urgency field to Notification struct
  • Add actions field to Notification struct
  • Use itertools for chunking vector items by pairs (chunks not available in std::iter::Iterator yet)
  • Default: Urgency::Normal
  • No custom From<T> for Value or OwnedValue (all done through #[derive(...)])

@TTWNO TTWNO linked an issue Mar 7, 2024 that may be closed by this pull request
Remove use of println!()
@TTWNO TTWNO force-pushed the notification-improvements branch from 31744c2 to 7b4a686 Compare March 7, 2024 00:21
@TTWNO
Copy link
Member Author

TTWNO commented Mar 7, 2024

Do not merge this yet. I still want to make certain structs PartialEq, Eq, etc.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 16.60%. Comparing base (efd02b7) to head (f49f940).
Report is 11 commits behind head on main.

Files Patch % Lines
odilia-notify/src/urgency.rs 0.00% 11 Missing ⚠️
odilia-notify/src/notification.rs 83.33% 3 Missing ⚠️
odilia-notify/src/action.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   16.08%   16.60%   +0.51%     
==========================================
  Files          20       22       +2     
  Lines        1616     1650      +34     
==========================================
+ Hits          260      274      +14     
- Misses       1356     1376      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TTWNO TTWNO merged commit 3dd192f into main Mar 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Notification struct + Type impl for Notifications
1 participant