Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable Doctrine SQL Column Length #155

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Crovitche-1623
Copy link

@Crovitche-1623 Crovitche-1623 commented Nov 16, 2023

Using the form type supplied, the number is automatically converted to the E164 format. The E164 format has a maximum of 15 digits (without the "+"), so the length must be configurable, as the doctrine format is 35 characters long and hard-coded.

With my PR, it's now possible to configure the length of the column. For instance:

#[ORM\Column(type: PhoneNumberType::NAME, length: 16)]
private ?PhoneNumber $phoneNumber = null;

#156

Add the possibility to configure the Doctrine SQL Column Length
@maxhelias
Copy link
Collaborator

Can you add a line to the changelog and rebase pls ?

@Crovitche-1623
Copy link
Author

Done

@maxhelias
Copy link
Collaborator

Thanks !

@maxhelias maxhelias merged commit d08880d into odolbeau:master Nov 16, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants