Obtain props from function for attached Owl components #3463
+2,929
−2,586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-public-widgets-ged, it needs to be retargeted before it can be merged. |
ged-odoo
force-pushed
the
master-public-widgets-ged
branch
2 times, most recently
from
86f4063 to
6bbd579
Compare
ged-odoo
force-pushed
the
master-public-widgets-ged
branch
from
6bbd579 to
21714ef
Compare
bso-odoo
force-pushed
the
master-public-widgets-bso
branch
from
0e5c60d to
c1afdba
Compare
ged-odoo
force-pushed
the
master-public-widgets-ged
branch
2 times, most recently
from
cc9630a to
9e0215d
Compare
Base automatically changed from
master-public-widgets-ged
to
master-public-widgets
October 31, 2024 13:55
bso-odoo
force-pushed
the
master-public-widgets-bso
branch
5 times, most recently
from
c876103 to
4417ade
Compare
FrancoisGe
reviewed
Nov 4, 2024
| return; | ||
| } | ||
| // Escape special characters to make the jQuery selector to work. | ||
| hash = '#' + $.escapeSelector(hash.substring(1)); |
There was a problem hiding this comment.
Added TODO comment about getting rid of JQ there: that escaping is non-trivial, and it might have to be added in a place like dom.js - but it is surprisingly only used in that one location.
bso-odoo
force-pushed
the
master-public-widgets-bso
branch
3 times, most recently
from
fa11dd4 to
4dc83ce
Compare
bso-odoo
force-pushed
the
master-public-widgets-bso
branch
2 times, most recently
from
d23d65f to
bfdfbd2
Compare
bso-odoo
force-pushed
the
master-public-widgets-bso
branch
6 times, most recently
from
06148f2 to
03a4927
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
from
2cc48c9 to
b746ee1
Compare
bso-odoo
force-pushed
the
master-public-widgets-bso
branch
from
03a4927 to
1a54cdc
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
from
62d6dc8 to
bf2b6b1
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
2 times, most recently
from
1d47261 to
d11e6df
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
from
f41bf58 to
7fd0d01
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
from
4408e26 to
daa5c3e
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
4 times, most recently
from
bd90205 to
3b99803
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
from
4775765 to
163eaa9
Compare
robinlej
force-pushed
the
master-public-widgets
branch
3 times, most recently
from
6910b8e to
a06a3d5
Compare
ged-odoo
force-pushed
the
master-public-widgets
branch
from
5d1b4c3 to
72f8a28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.