Convert basic option social media #3804
Open
+145
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
FrancoisGe
force-pushed
the
master-mysterious-egg-fge-2
branch
from
01c3aa9 to
7e563b8
Compare
loco-odoo
reviewed
Dec 20, 2024
| </BuilderRow> | ||
|
|
||
| <BuilderRow label.translate="Color"> | ||
| <BuilderCheckbox classAction="'no_icon_color'"/> |
There was a problem hiding this comment.
I think the checkbox should be active at the opposite condition
| via selectClass (also fixes the fact that nothing is selected | ||
| if fa-1x is actually used on the icon in this case) --> | ||
| <!-- <BuilderButton classAction="'fa-1x'" dependencies="'fake'"/> | ||
| <BuilderButton classAction="'fa-lg'" dependencies="'fake'"/> --> |
There was a problem hiding this comment.
but you still need to remove those classes at the 'clean' or I missed something?
| await setupWebsiteBuilder(`<div class="test-options-target">b</div>`); | ||
| await contains(":iframe .test-options-target").click(); | ||
| expect(".options-container").toBeDisplayed(); | ||
| await click(".we-bg-options-container .dropdown"); |
There was a problem hiding this comment.
nitpick: await contains().click to avoid click+animationFrame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.