[IMP] Add option to customize wait-for-psql.py timeout #341
+33
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to pass a custom timeout value for the `wait-for-psql.py` script to the container via the `PSQL_TIMEOUT` environment variable. The timeout of 30 seconds still remains the default.
mamiu
commented
Nov 28, 2020
| | cut -d " " -f3 \ | ||
| | sed 's/["\n\r]//g' | ||
| ) | ||
| fi |
There was a problem hiding this comment.
These changes are just editor code formatting.
mamiu
commented
Nov 28, 2020
| | cut -d " " -f3 \ | ||
| | sed 's/["\n\r]//g' | ||
| ) | ||
| fi |
mamiu
commented
Nov 28, 2020
| | cut -d " " -f3 \ | ||
| | sed 's/["\n\r]//g' | ||
| ) | ||
| fi |
mamiu
changed the title
|
@mamiu can you update this PR for 15, 16, 17 releases? |
|
@lathama Are you working for Odoo? I only wanna update this PR if I can be sure that someone's merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to pass a custom timeout value for the
wait-for-psql.pyscript to the container via thePSQL_TIMEOUTenvironment variable.The timeout of 30 seconds still remains the default.
Background
In our Kubernetes cluster the startup of the postgresql container takes sometimes a little longer than 30 seconds. This change offers users to adjust the timeout to a higher value to prevent the odoo container from getting stuck.