Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Dockerfile #470

wants to merge 1 commit into from

Conversation

freakynl
Copy link

Fixed version 14 code to be usable with proxy (is cleaner too).

This way one can set HTTP(S) proxy in ENV vars higher up and file and it will work. Most proxies won't allow the port GPG uses by default and it's not easy to get GPG working with proxy consistently in my tests.

This way it's not required and more conform instructions from PostgreSQL here: https://wiki.postgresql.org/wiki/Apt

Fixed version 14 code to be usable with proxy (is cleaner too)
@lathama
Copy link

lathama commented Mar 31, 2024

@freakynl is this still relevant with 15, 16, and 17? If not please close.

@freakynl
Copy link
Author

I didn't check but downloading keys via GPG servers doesn't start working magically via proxy (it's not HTTP/HTTPS and not using std allowed ports either) and I see no reason why you'd deviate from the PostgreSQL instructions like this in the first place. This deviation makes it less stable/predictable, doesn't work via proxy and doesn't seem to add anything useful at all from my perspective.

I provided this fix because an external party to us needed to build this on a build street that's behind a proxy. I don't use odoo. From my perspective it would be wise if you'd incorporate this and get proxy support with it and being more compatible with upstream instructions but do as you please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants