-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] Payroll: Salary attachment report #11064
Conversation
bf4a22f
to
f72316d
Compare
f72316d
to
0bf202e
Compare
0bf202e
to
cf6f875
Compare
Hi @dikd-odoo - this is ready for a first-round review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @larm-odoo great work on this documentation! I did run into an issue where I was not able to find the Salary Attachment report under Payroll > Reporting. Might be something I missed, but could you double check if there is a configuration needed?
cf6f875
to
43dbc18
Compare
Hi @dikd-odoo - thank you for your review! I put in a comment from one of your edits, that the report is a default one. If you go to a 17.0 runbot, there should be info in there, and the report is visible. LMK if you have any issues finding it! |
Hi @larm-odoo thank you for the clarification! I checked the flow in a 17.0 runbot and it went smoothly. This should be ready to go, with the note that the 18.0 will be updated to reflect configuration changes (Salary Attachment Report not a pre-configured report). Let me know if you have any questions, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @larm-odoo -- just finished my Final Review. Only have a few notes that require your attention. Once you make those necessary adjustments, feel free to move this to Tech Review. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving!
43dbc18
to
ca22ce1
Compare
Hi @samueljlieber - this is ready for a tech review when you have a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @larm-odoo! Nice work- your changes look good to me, just a couple quick fixes.
.....
@robodoo delegate=larm-odoo
ca22ce1
to
99aec52
Compare
@robodoo r+ |
closes #11064 Signed-off-by: Lara Martini (larm) <[email protected]>
closes #11064 Signed-off-by: Lara Martini (larm) <[email protected]>
Adding the salary attachment reporting doc as a separate stand-alone doc instead of combined in a reporting doc with all reports on it.
Original task card for this PR.