-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Appraisals: Skills Report - highest improvement #11112
[IMP] Appraisals: Skills Report - highest improvement #11112
Conversation
Hi @Felicious - this is ready for a first-round review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job adding this use case, @larm-odoo (:
I just had one super small suggestion, and that's it 😊
b6476d9
to
e4fb884
Compare
Hi @ksc-odoo - this is ready for a final review! Just added the new section on the bottom, which was added in 17.4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @larm-odoo -- just gave this a Final Review. Nice, clean content. Only have one minor comment. Once you implement the necessary adjustments, feel free to tag this for tech review.
e4fb884
to
a9a5194
Compare
Hi @samueljlieber - this is ready for a tech review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @larm-odoo, thank you for your work! Approving with two quick fixes :)
...
@robodoo delegate=larm-odoo
a9a5194
to
c151368
Compare
@robodoo r+ |
closes #11112 Signed-off-by: Lara Martini (larm) <[email protected]>
There's a new feature in the Skills Reporting in Odoo Online, where you can determine the employee with the highest improvement levels for their skills. Adding this use case to Odoo Online and Master.
The only change is the new section at the bottom.
Original project task card for this PR.