[IMP] pivot: persist defer update

src/components/grid/grid.ts

@@ -257,6 +257,7 @@ export class Grid extends Component<Props, SpreadsheetChildEnv> {
     "Ctrl+Z": () => this.env.model.dispatch("REQUEST_UNDO"),
     "Ctrl+Y": () => this.env.model.dispatch("REQUEST_REDO"),
     F4: () => this.env.model.dispatch("REQUEST_REDO"),
+    F9: () => this.env.model.dispatch("EVALUATE_CELLS"),
     "Ctrl+B": () =>
       this.env.model.dispatch("SET_FORMATTING", {
         sheetId: this.env.model.getters.getActiveSheetId(),

src/components/side_panel/pivot/pivot_side_panel/pivot_side_panel_store.ts

@@ -17,10 +17,12 @@ import {
 export class PivotSidePanelStore extends SpreadsheetStore {
   mutators = ["reset", "deferUpdates", "applyUpdate", "discardPendingUpdate", "update"] as const;
 
-  private updatesAreDeferred: boolean = false;
+  private updatesAreDeferred: boolean;
   private draft: PivotCoreDefinition | null = null;
   constructor(get: Get, private pivotId: UID) {
     super(get);
+    this.updatesAreDeferred =
+      this.getters.getPivotCoreDefinition(this.pivotId).deferUpdates ?? false;
   }
 
   handle(cmd: Command) {
@@ -121,10 +123,13 @@ export class PivotSidePanelStore extends SpreadsheetStore {
   }
 
   deferUpdates(shouldDefer: boolean) {
-    this.updatesAreDeferred = shouldDefer;
     if (shouldDefer === false && this.draft) {
+      this.draft.deferUpdates = false;
       this.applyUpdate();
+    } else {
+      this.update({ deferUpdates: shouldDefer });
     }
+    this.updatesAreDeferred = shouldDefer;
   }
 
   applyUpdate() {

src/types/pivot.ts

@@ -52,6 +52,7 @@ export interface CommonPivotCoreDefinition {
   rows: PivotCoreDimension[];
   measures: PivotCoreMeasure[];
   name: string;
+  deferUpdates?: boolean;
 }
 
 export interface SpreadsheetPivotCoreDefinition extends CommonPivotCoreDefinition {

tests/grid/grid_component.test.ts

@@ -72,7 +72,13 @@ import {
   getSelectionAnchorCellXc,
   getStyle,
 } from "../test_helpers/getters_helpers";
-import { mockChart, mountSpreadsheet, nextTick, typeInComposerGrid } from "../test_helpers/helpers";
+import {
+  mockChart,
+  mountSpreadsheet,
+  nextTick,
+  spyModelDispatch,
+  typeInComposerGrid,
+} from "../test_helpers/helpers";
 import { mockGetBoundingClientRect } from "../test_helpers/mock_helpers";
 jest.mock("../../src/components/composer/content_editable_helper", () =>
   require("../__mocks__/content_editable_helper")
@@ -785,6 +791,12 @@ describe("Grid component", () => {
       await simulateClick(".o-filter-icon");
       expect(fixture.querySelectorAll(".o-filter-menu")).toHaveLength(1);
     });
+
+    test("F9 triggers a re-evaluation of the grid", () => {
+      const spyDispatch = spyModelDispatch(model);
+      keyDown({ key: "F9" });
+      expect(spyDispatch).toHaveBeenCalledWith("EVALUATE_CELLS");
+    });
   });
 
   describe("Grid Scroll", () => {

tests/pivots/spreadsheet_pivot/spreadsheet_pivot_side_panel.test.ts

@@ -305,6 +305,21 @@ describe("Spreadsheet pivot side panel", () => {
     expect(fixture.querySelectorAll(".pivot-dimension")).toHaveLength(0);
   });
 
+  test("defer update option is persistent", async () => {
+    const pivotId = model.getters.getPivotIds()[0];
+    expect(".pivot-defer-update input").toHaveValue(false);
+    expect(model.getters.getPivotCoreDefinition(pivotId).deferUpdates).toBeFalsy();
+
+    await click(fixture, ".pivot-defer-update input");
+    expect(".pivot-defer-update input").toHaveValue(true);
+    expect(model.getters.getPivotCoreDefinition(pivotId).deferUpdates).toBeTruthy();
+
+    await click(fixture, ".o-sidePanelClose");
+    env.openSidePanel("PivotSidePanel", { pivotId });
+    await nextTick();
+    expect(".pivot-defer-update input").toHaveValue(true);
+  });
+
   test("Measures have the correct default aggregator", async () => {
     setCellContent(model, "A1", "amount");
     setCellContent(model, "A2", "10");