Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] pivot: allow to sort the pivot on any column #4998

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hokolomopo
Copy link
Contributor

Description

This commit allows the user to right click on a pivot cell to sort the pivot on that column.

Task: 3989395

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Sep 18, 2024

Pull request status dashboard

In the pivot we referred to the sort order with `asc` and `desc`,
while when sorting range we used `ascending` and `descending`.

This commit homogenizes everything into the type `SortDirection` with
values `asc` and `desc`.

Task: 3989395
This commit allows the user to right click on a pivot cell to sort
the pivot on that column.

Task: 3989395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants