Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pivot: divergent collaborative duplicated pivot name #5010

Open
wants to merge 1 commit into
base: saas-17.4
Choose a base branch
from
Open

[FIX] pivot: divergent collaborative duplicated pivot name #5010

wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

@LucasLefevre LucasLefevre commented Sep 20, 2024 •
edited
Loading

Description:

Currently, if two users are connected to the same spreadsheet, both have
different languages and one of them duplicates a pivot: the spreadsheet
states have diverged because _t(...) gives two different results on both
sides.

Note that the command should ideally be upgraded with a script, but it's
not possible to get the original pivot name on the upgrade platform.
Task: 4199949

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Sep 20, 2024

Pull request status dashboard

@LucasLefevre
[FIX] pivot: divergent collaborative duplicated pivot name
c74549f 
Currently, if two users are connected to the same spreadsheet, both have
different languages and one of them duplicates a pivot: the spreadsheet
states have diverged because `_t(...)` gives two different results on both
sides.

Note that the command should ideally be upgraded with a script, but it's
not possible to get the original pivot name on the upgrade platform.

Task: 4199949
@LucasLefevre LucasLefevre force-pushed the saas-17.4-divergent-duplicated-pivot-name-lul branch from 0931f0b to c74549f Compare September 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasLefevre @robodoo