[IMP] autofill: support date autofill #5011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Sep 23, 2024
rrahir
force-pushed
the
master-autofill-dates-rar
branch
2 times, most recently
from
491296d
to
20a2ed0
Compare
src/helpers/dates.ts
Outdated
Comment on lines
140
to
142
| copy() { | ||
| return DateTime.fromTimestamp(this.getTime()); | ||
| } |
There was a problem hiding this comment.
I wonder if this is a good method. it looks like a new constructor, and has only 1 usage...
Also, it only copies the time.
VincentSchippefilt
approved these changes
Sep 27, 2024
src/registries/autofill_rules.ts
Outdated
Comment on lines
134
to
136
| if (group.length === 2) { | ||
| group.length * (group[1] - group[0]); | ||
| } |
There was a problem hiding this comment.
looks like a useless if: no side effect and no return
Task: 4173602
rrahir
force-pushed
the
master-autofill-dates-rar
branch
from
20a2ed0
to
ebab826
Compare
|
let's go for 18.0 :o |
LucasLefevre
approved these changes
Oct 1, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 4173602
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist