Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] xlsx: fix table total row export #5017

Closed
wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

In Excel, the total row of a table should only contain either:

  • string cells
  • formula cells, with an attribute table column to mark them as custom total formulas.

Task: 4206619

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

In Excel, the total row of a table should only contain either:
- string cells
- formula cells, with an attribute table column to mark them as custom
total formulas.

Task: 4206619
@robodoo
Copy link
Collaborator

robodoo commented Sep 24, 2024

Pull request status dashboard

@rrahir
Copy link
Collaborator

rrahir commented Sep 30, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 30, 2024
In Excel, the total row of a table should only contain either:
- string cells
- formula cells, with an attribute table column to mark them as custom
total formulas.

closes #5017

Task: 4206619
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Sep 30, 2024
@fw-bot fw-bot deleted the saas-17.4-xlsx-export-table-total-adrm branch October 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants