Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] xlsx: convert #REF at export to xlsx #5019

Closed
wants to merge 2 commits into from

Commits on Sep 24, 2024

  1. [FIX] parser: inconsistent handling of #REF

    Depending on how we get a formula with #REF, the parser can have
    different behavior even if the formula is the same.
    
    - If we write directly =#REF (or it comes from a snapshot), the parser
      will throw an error.
    - If we write =A1, then delete the row 1 to get =#REF, the parser will
    return a REFERENCE token with an #REF value.
    
    This is a bit of a problem when exporting the data to xlsx: since
    we parse the formulas to know whether we need to export it, we get
    a different result depending on how we got the #REF.
    
    Task: 4207052
    hokolomopo committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0fe8d31 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. [FIX] xlsx: convert #REF at export to xlsx

    Reference errors in excel are #REF!, not #REF.
    
    Task: 4207052
    hokolomopo authored and LucasLefevre committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2ae5d66 View commit details
    Browse the repository at this point in the history