Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] ColorPicker: conditionally hide reset button #5025

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] ColorPicker: conditionally hide reset button #5025

wants to merge 1 commit into from

Conversation

dhrp-odoo
Copy link
Contributor

Description:

Previously, in the Conditional Formatting Color Scale rule editor, clicking the "Reset" button in the color picker gives a traceback.

This PR resolves the issue by conditionally hiding the "Reset" button when resetting the color is not applicable.

Task: 4102704

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Sep 26, 2024

Pull request status dashboard

hokolomopo
hokolomopo reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your plan to fix the other side panel ? Create PRs in theire respecive versions once this one is merged ?

src/components/color_picker/color_picker.ts Outdated Show resolved Hide resolved
@dhrp-odoo
[FIX] ColorPicker: Conditionally hide reset button
0867822 
Previously, in the Conditional Formatting Color Scale rule editor,
clicking the "Reset" button in the color picker gives a traceback.

This commit resolves the issue by conditionally hiding the "Reset"
button when resetting the color is not applicable.

Task: 4102704
@dhrp-odoo dhrp-odoo force-pushed the 16.0-fix-color-picker-reset-dhrp branch from f331e6a to 0867822 Compare September 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokolomopo hokolomopo hokolomopo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhrp-odoo @robodoo @hokolomopo