[REM] UUID: remove fast strategy #5030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THe fast strategy for uuid generator was introduced to speed up the startup of a model, specifically when generating cells which could be numerous and the calls to crypto could become a hassle. However, we realised later on that a uuid was useless for that specific purpose. More specifically, a uuid is useful to generate unique identifiers that will be shared accross users to avoid collisions in multi-user context (i.e. concurrent updates). In other cases, shortcutting the uuid generator to become a simple incremented integer value is either wrong or shows the uselessness of calling uuidGenerator in the first place. Task: 4216816
|
|
hokolomopo
reviewed
Sep 30, 2024
Using uuids in core plugins is either: - wrong if the id is supposed to be shared across users since a different one would be generated for each users. - useless if they aren't shared: the id doesn't need to be unique. This commit removes the `uuidGenerator` from core plugins because it shouldn't be used. The use in the Table plugin was useless (the id is never shared, it's not part of any table core command) Task: 4216816
LucasLefevre
approved these changes
Sep 30, 2024
|
robodoo r+ |
|
@rrahir @VincentSchippefilt because this PR has multiple commits, I need to know how to merge it:
|
|
robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Oct 7, 2024
THe fast strategy for uuid generator was introduced to speed up the startup of a model, specifically when generating cells which could be numerous and the calls to crypto could become a hassle. However, we realised later on that a uuid was useless for that specific purpose. More specifically, a uuid is useful to generate unique identifiers that will be shared accross users to avoid collisions in multi-user context (i.e. concurrent updates). In other cases, shortcutting the uuid generator to become a simple incremented integer value is either wrong or shows the uselessness of calling uuidGenerator in the first place. Task: 4216816 Part-of: #5030 Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Using uuids in core plugins is either: - wrong if the id is supposed to be shared across users since a different one would be generated for each users. - useless if they aren't shared: the id doesn't need to be unique. This commit removes the `uuidGenerator` from core plugins because it shouldn't be used. The use in the Table plugin was useless (the id is never shared, it's not part of any table core command) closes #5030 Task: 4216816 Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THe fast strategy for uuid generator was introduced to speed up the startup of a model, specifically when generating cells which could be numerous and the calls to crypto could become a hassle. However, we realised later on that a uuid was useless for that specific purpose. More specifically, a uuid is useful to generate unique identifiers that will be shared accross users to avoid collisions in multi-user context (i.e. concurrent updates).
In other cases, shortcutting the uuid generator to become a simple incremented integer value is either wrong or shows the uselessness of calling uuidGenerator in the first place.
Task: 4216816
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist