Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] autocomplete: Stop the range selection after selecting a pivot … #5033

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Sep 30, 2024

…proposal

The proposal selection of pivot autocomplete would put the composer in an invalid state where we inserted some text while in range selection mode without modifying the said state.

How to reproduce:

  • Go to a runbot and insert a pivot in a spreadsheet
  • type =pivot(
  • Your have the dropddown taht suggests the id 1
  • type enter to select it --> your composer has =pivot(1 as content
  • use the arrowkeys to the up/down --> It pipes a cell reference next to the pivotID

Task: 4176481

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4980

@robodoo
Copy link
Collaborator

robodoo commented Sep 30, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Sep 30, 2024

@rrahir @LucasLefevre cherrypicking of pull request #4980 failed.

stdout:

Auto-merging src/helpers/pivot/pivot_composer_helpers.ts
CONFLICT (content): Merge conflict in src/helpers/pivot/pivot_composer_helpers.ts
Auto-merging tests/composer/auto_complete/pivot_auto_complete_store.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

…proposal

The proposal selection of pivot autocomplete would put the composer in
an invalid state where we inserted some text while in range selection
mode without modifying the said state.

How to reproduce:
- Go to a runbot and insert a pivot in a spreadsheet
- type =pivot(
- Your have the dropddown taht suggests the id 1
- type enter to select it
--> your composer has =pivot(1 as content
- use the arrowkeys to the up/down
--> It pipes a cell reference next to the pivotID

Task: 4176481
X-original-commit: e02a432
@rrahir rrahir force-pushed the 18.0-saas-17.4-fix-pivot-autocomplete-rar-ED4c-fw branch from 4fab9db to 5d52e2a Compare September 30, 2024 08:37
@rrahir
Copy link
Collaborator

rrahir commented Sep 30, 2024

@robodoo r+

@robodoo robodoo closed this in d89d673 Sep 30, 2024
@fw-bot fw-bot deleted the 18.0-saas-17.4-fix-pivot-autocomplete-rar-ED4c-fw branch October 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants