Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] pivot: finer grained cycle detection #5073

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Oct 11, 2024

Description:

Steps to reproduce:

  • insert a fixed pivot (not dynamic!)
  • insert a new calculated measure
  • in the calculated measure formula, reference one of a cell which contains a header formula

=> the cell becomes a #CYCLE even though there's no circular dependendy
between the calculated measure and the other dimension header

Task: 4214188

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5026

Steps to reproduce:

- insert a fixed pivot (not dynamic!)
- insert a new calculated measure
- in the calculated measure formula, reference one of a cell which contains a
  header formula

=> the cell becomes a #CYCLE even though there's no circular dependendy
   between the calculated measure and the other dimension header

Task: 4214188
X-original-commit: 77c19d8
@robodoo
Copy link
Collaborator

robodoo commented Oct 11, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Oct 11, 2024

@LucasLefevre @rrahir this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@LucasLefevre
Copy link
Collaborator

LucasLefevre commented Oct 11, 2024 via email

robodoo pushed a commit that referenced this pull request Oct 11, 2024
Steps to reproduce:

- insert a fixed pivot (not dynamic!)
- insert a new calculated measure
- in the calculated measure formula, reference one of a cell which contains a
  header formula

=> the cell becomes a #CYCLE even though there's no circular dependendy
   between the calculated measure and the other dimension header

closes #5073

Task: 4214188
X-original-commit: 77c19d8
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo robodoo closed this Oct 11, 2024
@robodoo robodoo added the 18.1 label Oct 11, 2024
@fw-bot fw-bot deleted the master-18.0-finer-grained-pivot-cycle-lul-sst3-fw branch October 25, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants